[Vulkan] Add support for MoltenVK on macOS #256
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm-beanz
commented
Jun 18, 2025
llvm-beanz
commented
Jun 18, 2025
farzonl
approved these changes
Jun 23, 2025
farzonl
reviewed
Jun 23, 2025
| @@ -176,6 +176,9 @@ DescriptorSets: | |||
| # https://github.com/microsoft/DirectXShaderCompiler/issues/7512 | |||
| # XFAIL: DXC-Vulkan | |||
|
|
|||
| # No idea what is going on here, but Out1 and Out3 are coming through as 0's. | |||
| # XFAIL: Clang && Vulkan-Darwin | |||
There was a problem hiding this comment.
Particle life is probably harder, but this one feel like we should have a follow up task to figure out what is going wrong.
bogner
approved these changes
Jun 24, 2025
|
I converted this PR to a draft because as much as I would like this to work, it is failing like crazy across a lot of tests right now. It looks like bugs in the SPIRV->Metal translator as well as MoltenVK doing additional API validation that other drivers don't seem to be doing. I'll revisit this in the future, but for now... it's going to just sit around. |
This adds extensions as a queryable capability through the device interface for Vulkan. This also gates adding extensions that we had previously been using based on their availabiltiy. As a last bit, this does include one small line added in the Changes to enable MoltenVK on Apple. When targeting Apple platforms the VK_KHR_PORTABILITY is always enabled. That extension is always required on Apple platforms so we can hard code that one.
This gets Vulkan support working on macOS if the Vulkan SDK and MoltenVK are available. All current Vulkan tests except particle_life pass with Vulkan on macOS with DXC, and sign.32.test fails with Clang.
These changes are not actually needed, I just didn't have the linkage and paths correct.
This seems to be working, although it's not great that the library is in a weird SDK path...
llvm-beanz
force-pushed
the
cbieneman/moltenvk
branch
from
91fd20f to
475d484
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets Vulkan support working on macOS if the Vulkan SDK and MoltenVK are available. All current Vulkan tests except particle_life pass with Vulkan on macOS with DXC, and sign.32.test fails with Clang.